Attention is currently required from: Himanshu Sahdev, Julius Werner, Tarun Tuli.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email )
Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/75641/comment/48f8dce5_9be833af :
PS1, Line 295: config VBOOT_GSC_BOARD_ID
don't we need/want to remove this config existence from `src/security/vboot`?
I think using a config to store the default value is fine even if we don't override it in practice. We do this for other parameters, e.g. all the key paths (VBOOT_ROOT_KEY, etc). But I can update the help text to make it clear that the specific board IDs don't need to be set in coreboot.
(+Julius to check this all makes sense.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75641?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df
Gerrit-Change-Number: 75641
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 05 Jun 2023 23:26:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-MessageType: comment