Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44625 )
Change subject: util/abuild: Don't pass kconfig output through head ......................................................................
util/abuild: Don't pass kconfig output through head
Closing stdout early seems to have a detrimental effect on kconfig on a system under high load (e.g. when doing lots of builds in parallel).
Change-Id: I6987f1deac596124c7b397bf7bc5a78d691cc538 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/abuild/abuild 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44625/1
diff --git a/util/abuild/abuild b/util/abuild/abuild index c94b6b9..53a988b9 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -823,7 +823,7 @@ printf "%s" "$configoptions" > "$TMPCFG" $MAKE -j "$cpus" DOTCONFIG="$TMPCFG" obj="$TARGET/temp" objutil="$TARGET/sharedutils" allnoconfig printf "%s" "$configoptions" >> "$TMPCFG" - yes "" 2>/dev/null | $MAKE -j "$cpus" DOTCONFIG="$TMPCFG" obj="$TARGET/temp" objutil="$TARGET/sharedutils" oldconfig 2>/dev/null |head > /dev/null + yes "" 2>/dev/null | $MAKE -j "$cpus" DOTCONFIG="$TMPCFG" obj="$TARGET/temp" objutil="$TARGET/sharedutils" oldconfig BUILDPREFIX= if [ "$scanbuild" = "true" ]; then scanbuild_out=$TARGET/sharedutils-scanbuild
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44625 )
Change subject: util/abuild: Don't pass kconfig output through head ......................................................................
Patch Set 2: Code-Review+1
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44625 )
Change subject: util/abuild: Don't pass kconfig output through head ......................................................................
Patch Set 2: Code-Review+2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44625 )
Change subject: util/abuild: Don't pass kconfig output through head ......................................................................
Patch Set 2:
Why was this done in the first place? Cosmetics?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44625 )
Change subject: util/abuild: Don't pass kconfig output through head ......................................................................
Patch Set 2:
Patch Set 2:
Why was this done in the first place? Cosmetics?
I added that ~6 years ago, but I don't really see a reason, esp. with it all wrapped in >/dev/null... Let's be verbose instead.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44625 )
Change subject: util/abuild: Don't pass kconfig output through head ......................................................................
util/abuild: Don't pass kconfig output through head
Closing stdout early seems to have a detrimental effect on kconfig on a system under high load (e.g. when doing lots of builds in parallel).
Change-Id: I6987f1deac596124c7b397bf7bc5a78d691cc538 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44625 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/abuild/abuild 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/util/abuild/abuild b/util/abuild/abuild index c94b6b9..53a988b9 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -823,7 +823,7 @@ printf "%s" "$configoptions" > "$TMPCFG" $MAKE -j "$cpus" DOTCONFIG="$TMPCFG" obj="$TARGET/temp" objutil="$TARGET/sharedutils" allnoconfig printf "%s" "$configoptions" >> "$TMPCFG" - yes "" 2>/dev/null | $MAKE -j "$cpus" DOTCONFIG="$TMPCFG" obj="$TARGET/temp" objutil="$TARGET/sharedutils" oldconfig 2>/dev/null |head > /dev/null + yes "" 2>/dev/null | $MAKE -j "$cpus" DOTCONFIG="$TMPCFG" obj="$TARGET/temp" objutil="$TARGET/sharedutils" oldconfig BUILDPREFIX= if [ "$scanbuild" = "true" ]; then scanbuild_out=$TARGET/sharedutils-scanbuild