Change in coreboot[master]: soc/intel/common/block: Enable PMC IPC driver

[Brandon Breitenstein (Code Review)]

Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )

Change subject: soc/intel/common/block: Enable PMC IPC driver
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... 
File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... 
PS10, Line 610: if (ipcsts & PMC_IPC_STS_BUSY)
              : 			return CB_SUCCESS;
> I am confused. […]

I think somewhere is the moving this patch around a few times this got messed up. You are correct it should be a check of the busy bit until timeout not a return when the busy bit is hit. Will fix this.

https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... 
PS10, Line 614:
> Does there need to be a delay instead of a tight loop for checking the status register?

There is no delay required but I will add a 1us delay here to avoid the tight loop hammering the register