Change in coreboot[master]: mb/google/dedede/var/madoo: Fix DPTF passive and critical policies

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51456 )

Change subject: mb/google/dedede/var/madoo: Fix DPTF passive and critical policies
......................................................................

mb/google/dedede/var/madoo: Fix DPTF passive and critical policies

Some of the temperature sensors defined in baseboard do not exist in
madoo. With the format the DPTF policies are defined in madoo, all the
entries from the baseboard are included and then the overrides applied.
This causes the non-existent DPTF devices to be exported in the ACPI
table and in turn OS reading invalid temperatures. Fix the format for
DPTF passive and critical policies.

BUG=b:182513022
BRANCH=dedede
TEST=Build and boot to OS in madoo. Ensure that the DPTF entries look
correct in both static.c and SSDT tables i.e. passive and critical
policies for applicable devices only are present.

Signed-off-by: Karthikeyan Ramasubramanian 
Change-Id: Idc5d0b357d61b9346b4d20ec8322b124c9655b4c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51456
Tested-by: build bot (Jenkins) 
Reviewed-by: Evan Green 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Ben Kao 
Reviewed-by: Sumeet R Pawnikar 
---
M src/mainboard/google/dedede/variants/madoo/overridetree.cb
1 file changed, 8 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Sumeet R Pawnikar: Looks good to me, approved
  Evan Green: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved
  Ben Kao: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb
index e754882..7acacb0 100644
--- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb
@@ -69,8 +69,14 @@
    device domain 0 on
    	device pci 04.0 on
    		chip drivers/intel/dptf
-				register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU, 65, 1000)"
-				register "policies.critical[0]" = "DPTF_CRITICAL(CPU, 100, SHUTDOWN)"
+				register "policies.passive" = "{
+					[0] = DPTF_PASSIVE(CPU, CPU, 65, 1000),
+					[1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 80, 60000),
+					[2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 55, 15000)}"
+				register "policies.critical" = "{
+					[0] = DPTF_CRITICAL(CPU, 100, SHUTDOWN),
+					[1] = DPTF_CRITICAL(TEMP_SENSOR_0, 90, SHUTDOWN),
+					[2] = DPTF_CRITICAL(TEMP_SENSOR_1, 80, SHUTDOWN)}"
    			register "controls.power_limits.pl1" = "{
    					.min_power = 4800,
    					.max_power = 6000,