Change in coreboot[master]: mb/google/dedede: Fill VR Configuration Values from devicetree

[Meera Ravindranath (Code Review)]

Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45825 )

Change subject: mb/google/dedede: Fill VR Configuration Values from devicetree
......................................................................

mb/google/dedede: Fill VR Configuration Values from devicetree

BUG=b:167472333
TEST=Build and boot dedede and observe the slope and offset values
     getting updated in the fsp debug log

Signed-off-by: Meera Ravindranath 
Change-Id: I3ea32218040263f0abef9b9dd4c52efb16289fd7
---
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/45825/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
index 1f72eb1..22c62e7 100644
--- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
@@ -163,6 +163,15 @@
    # register "common_soc_config.<variable_name>" = "value"
    register "common_soc_config.chipset_lockdown" = CHIPSET_LOCKDOWN_COREBOOT

+	# VR config settings
+	# Imon Slope correction specified in 1/100 increment values. Range is 0-200.
+	# Eg: 125 = 1.25
+	register "ImonSlope" = "100"
+
+	# Imon offset correction. Value is a 2's complement signed integer. Units 1/1000, Range 0-63999.
+	# For an offset = 12.580, use 12580
+	register "ImonOffset" = "0"
+
    # Skip the CPU repalcement check
    register "SkipCpuReplacementCheck" = "1"

[Meera Ravindranath (Code Review)]

Meera Ravindranath has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/45825 )

Change subject: mb/google/dedede: Fill VR Configuration Values from devicetree
......................................................................

mb/google/dedede: Fill VR Configuration Values from devicetree

BUG=b:167472333
TEST=Build and boot dedede and observe the slope and offset values
     getting updated in the fsp debug log

Signed-off-by: Meera Ravindranath 
Change-Id: I3ea32218040263f0abef9b9dd4c52efb16289fd7
---
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/45825/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45825 )

Change subject: mb/google/dedede: Fill VR Configuration Values from devicetree
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45825/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45825/2//COMMIT_MSG@7 
PS2, Line 7: Fill VR Configuration Values from devicetree
Maybe:
> Set VR values in devicetree
> Configure VR in devicetree

Change in coreboot[master]: mb/google/dedede: Configure VR in devicetree

[Meera Ravindranath (Code Review)]

Hello build bot (Jenkins), Maulik V Vaghela, Aamir Bohra, Ronak Kanabar, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45825

to look at the new patch set (#3).

Change subject: mb/google/dedede: Configure VR in devicetree
......................................................................

mb/google/dedede: Configure VR in devicetree

BUG=b:167472333
TEST=Build and boot dedede and observe the slope and offset values
     getting updated in the fsp debug log

Signed-off-by: Meera Ravindranath 
Change-Id: I3ea32218040263f0abef9b9dd4c52efb16289fd7
---
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/45825/3

Change in coreboot[master]: mb/google/dedede: Configure VR in devicetree

[Meera Ravindranath (Code Review)]

Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45825 )

Change subject: mb/google/dedede: Configure VR in devicetree
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45825/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45825/2//COMMIT_MSG@7 
PS2, Line 7: Fill VR Configuration Values from devicetree
> Maybe: […]

Done

Change in coreboot[master]: mb/google/dedede: Configure VR in devicetree

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45825 )

Change subject: mb/google/dedede: Configure VR in devicetree
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: mb/google/dedede: Configure VR in devicetree

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45825 )

Change subject: mb/google/dedede: Configure VR in devicetree
......................................................................

Patch Set 3:

Please rebase this change on top of the parent change.

Change in coreboot[master]: mb/google/dedede: Configure VR in devicetree

[Meera Ravindranath (Code Review)]

Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45825 )

Change subject: mb/google/dedede: Configure VR in devicetree
......................................................................

Patch Set 4:
> Patch Set 3:
>
> Please rebase this change on top of the parent change.

Done

Change in coreboot[master]: mb/google/dedede: Configure VR in devicetree

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45825 )

Change subject: mb/google/dedede: Configure VR in devicetree
......................................................................

mb/google/dedede: Configure VR in devicetree

BUG=b:167472333
TEST=Build and boot dedede and observe the slope and offset values
     getting updated in the fsp debug log

Signed-off-by: Meera Ravindranath 
Change-Id: I3ea32218040263f0abef9b9dd4c52efb16289fd7
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45825
Reviewed-by: Karthik Ramasubramanian 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
index 1f72eb1..73b0c61 100644
--- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
@@ -163,6 +163,16 @@
    # register "common_soc_config.<variable_name>" = "value"
    register "common_soc_config.chipset_lockdown" = CHIPSET_LOCKDOWN_COREBOOT

+	# VR config settings
+	# Imon Slope correction specified in 1/100 increment values. Range is 0-200.
+	# Eg: 125 = 1.25
+	register "ImonSlope" = "100"
+
+	# Imon offset correction. Value is a 2's complement signed integer.
+	# Units 1/1000, Range 0-63999.
+	# For an offset = 12.580, use 12580
+	register "ImonOffset" = "0"
+
    # Skip the CPU repalcement check
    register "SkipCpuReplacementCheck" = "1"