Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51792 )
Change subject: mb/google/zork/vilboz: Fix audio test failure on LTE SKU ......................................................................
mb/google/zork/vilboz: Fix audio test failure on LTE SKU
Use board id to switch acp_i2s_use_external_48mhz_osc enable.
BUG=b:181720406 BRANCH=firmware-zork-13434.B TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I085c39accd82bf72e4ebbc0394382ed4a7d4e901 Reviewed-on: https://review.coreboot.org/c/coreboot/+/51792 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kangheui Won khwon@chromium.org --- M src/mainboard/google/zork/variants/vilboz/variant.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve EricR Lai: Looks good to me, but someone else must approve Kangheui Won: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/vilboz/variant.c b/src/mainboard/google/zork/variants/vilboz/variant.c index 747e893..5006b92 100644 --- a/src/mainboard/google/zork/variants/vilboz/variant.c +++ b/src/mainboard/google/zork/variants/vilboz/variant.c @@ -40,6 +40,9 @@ struct soc_amd_picasso_config *soc_cfg; soc_cfg = config_of_soc();
+ if (board_id() <= 2 || board_id() == BOARD_ID_UNKNOWN) + return; + /* b:/174121847 Use external OSC to mitigate noise for WWAN sku. */ if (variant_has_wwan()) { soc_cfg->acp_i2s_use_external_48mhz_osc = 1;