Change in ...coreboot[master]: mainboard/google/cyan/acpi: Method _CRS must be Serialized

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Frans Hendriks (Code Review)

16 Apr 2019 16 Apr '19

12:06 p.m.

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32331

Change subject: mainboard/google/cyan/acpi: Method _CRS must be Serialized ......................................................................

mainboard/google/cyan/acpi: Method _CRS must be Serialized

IASL report warning 'Control Method should be made Serialized'. Change _CRS method to Serialized.

BUG=N/A TEST=Build Google Banon and Google Cyan

Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/google/cyan/acpi/codec_maxim.asl M src/mainboard/google/cyan/acpi/codec_realtek.asl 2 files changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/32331/1

diff --git a/src/mainboard/google/cyan/acpi/codec_maxim.asl b/src/mainboard/google/cyan/acpi/codec_maxim.asl index 81bec16..9319791 100644 --- a/src/mainboard/google/cyan/acpi/codec_maxim.asl +++ b/src/mainboard/google/cyan/acpi/codec_maxim.asl @@ -3,6 +3,7 @@ * * Copyright (C) 2012 Google Inc. * Copyright (C) 2015 Intel Corp. + * Copyright (C) 2018 Eltan B.V. * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as @@ -35,7 +36,7 @@ } })

- Method(_CRS, 0x0, NotSerialized) + Method(_CRS, 0x0, Serialized) { Name(SBUF,ResourceTemplate () { diff --git a/src/mainboard/google/cyan/acpi/codec_realtek.asl b/src/mainboard/google/cyan/acpi/codec_realtek.asl index 4a1d48d..6e4a638 100644 --- a/src/mainboard/google/cyan/acpi/codec_realtek.asl +++ b/src/mainboard/google/cyan/acpi/codec_realtek.asl @@ -3,6 +3,7 @@ * * Copyright (C) 2012 Google Inc. * Copyright (C) 2015 Intel Corp. + * Copyright (C) 2018 Eltan B.V. * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as @@ -26,7 +27,7 @@ Name (_DDN, AUDIO_CODEC_DDN) Name (_UID, 1)

- Method(_CRS, 0x0, NotSerialized) + Method(_CRS, 0x0, Serialized) { Name(SBUF,ResourceTemplate () {

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

Martin Roth (Code Review)

20 Apr 20 Apr

6:35 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32331 )

Change subject: mainboard/google/cyan/acpi: Method _CRS must be Serialized ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32331/1/src/mainboard/google/cyan/acpi/codec... File src/mainboard/google/cyan/acpi/codec_maxim.asl:

https://review.coreboot.org/#/c/32331/1/src/mainboard/google/cyan/acpi/codec... PS1, Line 6: * Copyright (C) 2018 Eltan B.V. What code in the new file are you copyrighting? How can you copyright the DELETION of code?

Again, please consider whether it's a "Creative and significant" change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Gerrit-Change-Number: 32331 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Sat, 20 Apr 2019 04:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

6:37 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32331 )

Change subject: mainboard/google/cyan/acpi: Method _CRS must be Serialized ......................................................................

Patch Set 1:

Btw, I don't mean to be unappreciative of the fixes. It's just that if everyone added a copyright line every time they made minor fixes, half of each file would just be copyrights.

The contributions are definitely appreciated.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Gerrit-Change-Number: 32331 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Sat, 20 Apr 2019 04:37:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

23 Apr 23 Apr

8:32 a.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32331 )

Change subject: mainboard/google/cyan/acpi: Method _CRS must be Serialized ......................................................................

Patch Set 1:

...

Patch Set 1:

Btw, I don't mean to be unappreciative of the fixes. It's just that if everyone added a copyright line every time they made minor fixes, half of each file would just be copyrights.

The contributions are definitely appreciated.

This patch was part of another patchset with more creative change. Got request to split, but agree the copyright should not be here.

Will create new patchset.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Gerrit-Change-Number: 32331 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Tue, 23 Apr 2019 06:32:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

12:32 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32331

to look at the new patch set (#2).

Change subject: mainboard/google/cyan/acpi: Method _CRS must be Serialized ......................................................................

mainboard/google/cyan/acpi: Method _CRS must be Serialized

IASL reports warning 'Control Method should be made Serialized'. Change _CRS method to Serialized.

BUG=N/A TEST=Build Google Banon and Google Cyan

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/32331/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Gerrit-Change-Number: 32331 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-MessageType: newpatchset

Matt DeVillier (Code Review)

26 Apr 26 Apr

8:09 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32331 )

Change subject: mainboard/google/cyan/acpi: Method _CRS must be Serialized ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Gerrit-Change-Number: 32331 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Fri, 26 Apr 2019 18:09:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

29 Apr 29 Apr

1:09 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32331 )

Change subject: mainboard/google/cyan/acpi: Method _CRS must be Serialized ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32331/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32331/1//COMMIT_MSG@7 PS1, Line 7: Method _CRS must be Serialized

...

mb/google/cyan/acpi: Serialize _CRS method

-- To view, visit https://review.coreboot.org/c/coreboot/+/32331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Gerrit-Change-Number: 32331 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Apr 2019 11:09:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

1:43 p.m.

New subject: Change in ...coreboot[master]: mainboard/google/cyan/acpi: Serialize _CRS method

Hello Matt DeVillier, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32331

to look at the new patch set (#4).

Change subject: mainboard/google/cyan/acpi: Serialize _CRS method ......................................................................

mainboard/google/cyan/acpi: Serialize _CRS method

IASL reports warning 'Control Method should be made Serialized'. Change _CRS method to Serialized.

BUG=N/A TEST=Build Google Banon and Google Cyan

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/32331/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Gerrit-Change-Number: 32331 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Matt DeVillier (Code Review)

4 May 4 May

12:38 a.m.

New subject: Change in ...coreboot[master]: mainboard/google/cyan/acpi: Serialize _CRS method

Matt DeVillier has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32331 )

Change subject: mainboard/google/cyan/acpi: Serialize _CRS method ......................................................................

mainboard/google/cyan/acpi: Serialize _CRS method

IASL reports warning 'Control Method should be made Serialized'. Change _CRS method to Serialized.

BUG=N/A TEST=Build Google Banon and Google Cyan

Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32331 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/cyan/acpi/codec_maxim.asl M src/mainboard/google/cyan/acpi/codec_realtek.asl 2 files changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved

diff --git a/src/mainboard/google/cyan/acpi/codec_maxim.asl b/src/mainboard/google/cyan/acpi/codec_maxim.asl index 81bec16..b412551 100644 --- a/src/mainboard/google/cyan/acpi/codec_maxim.asl +++ b/src/mainboard/google/cyan/acpi/codec_maxim.asl @@ -35,7 +35,7 @@ } })

- Method(_CRS, 0x0, NotSerialized) + Method(_CRS, 0x0, Serialized) { Name(SBUF,ResourceTemplate () {

-- To view, visit https://review.coreboot.org/c/coreboot/+/32331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffa097a2100cfa91efa3b617311500b83f839bce Gerrit-Change-Number: 32331 Gerrit-PatchSet: 5 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1828

days inactive

1845

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Frans Hendriks (Code Review)
Martin Roth (Code Review)
Matt DeVillier (Code Review)
Paul Menzel (Code Review)