Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42733 )
Change subject: [WIP] sb/amd/pi/hudson: Fixes for common GPIO API
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42733/8/src/southbridge/amd/pi/huds...
File src/southbridge/amd/pi/hudson/soc/smi.h:
PS8:
for everything apart from the defines soc/amd/common/block/include/amdblocks/smi.h should probably be used instead
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86ae40a3cdf335263d7e9e3dcfdd588947cdd9b1
Gerrit-Change-Number: 42733
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 20:26:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment