[M] Change in coreboot[main]: util/superiotool: add support for Nuvoton NCT6796D - coreboot-gerrit

18 Jan 2024


      Attention is currently required from: Felix Held, Name of user not set #1005314.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80003?usp=email )
Change subject: util/superiotool: add support for Nuvoton NCT6796D
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
i'd expect some of the bytes in the gpio ldns that correspond to the states of the inputs to be NANA
This part doesn't have dedicated input registers, but instead uses port data registers that have both input and output state, so NANA doesn't apply for all cases. One would need to check the associated status register first to see if the GPIO is configured as an input to determine if the data register should be NANA.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0ff940a17b0c38a5ca66e90dd4e075a2b04dcfc1
Gerrit-Change-Number: 80003
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Name of user not set #1005314
Gerrit-Attention: Name of user not set #1005314
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment