Attention is currently required from: Eric Lai, Ivy Jian, Nick Vaccaro, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79101?usp=email )
Change subject: mb/google/brox: Set TPM i2c config in device tree
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79101/comment/9470c632_0022fb99 :
PS4, Line 107: .early_init = 1,
Now that GSC is in I2C4, this should be for i2c[4].
https://review.coreboot.org/c/coreboot/+/79101/comment/e89ff4a0_41510cd0 :
PS4, Line 169: device ref i2c3 on end
Can be removed, not that nothing is in I2C3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79101?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10a7463effd85aec4551385963197bc1021319fe
Gerrit-Change-Number: 79101
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 28 Nov 2023 18:43:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment