Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Eric Lai, Elyes Haouas.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68593 )
Change subject: acpi/Kconfig: Remove unused ACPI_EINJ config option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
If this were entirely SOC-specific then I would agree that it should be kept with non-public downstream SOC code. But since EINJ is a standard ACPI feature and there is code in src/acpi/acpi.c to add the table then it's reasonable to keep things as-is for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99
Gerrit-Change-Number: 68593
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 17 Nov 2022 17:30:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment