Attention is currently required from: David Wu, Zhuohao Lee, Alan Huang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58105 )
Change subject: mb/google/brya/var/brask: Configurate the GPIOs of LAN
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58105/comment/983dabd4_8c9cec67
PS6, Line 7: Configurate
Configure
https://review.coreboot.org/c/coreboot/+/58105/comment/fb80bab2_2fb3a009
PS6, Line 9: Copy the default configuration from Puff.
: Update the 'stop_gpio' to GPP_H22.
: Remove 'wake'. ("WAKE#" is not a GPIO pin.)
Please format this as a list.
https://review.coreboot.org/c/coreboot/+/58105/comment/8c49ab63_e2e37770
PS6, Line 15: Build Pass
Maybe note down the command.
https://review.coreboot.org/c/coreboot/+/58105/comment/7e35b2a1_5c118821
PS6, Line 15: Pass
pass
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e82dbc1e6c68cbd84b603adc7fdc3ee1d4d3392
Gerrit-Change-Number: 58105
Gerrit-PatchSet: 6
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 22:35:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment