Change in coreboot[master]: drivers/i2c/generic: Only write DDN field if description not empty

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47781 )

Change subject: drivers/i2c/generic: Only write DDN field if description not empty
......................................................................

drivers/i2c/generic: Only write DDN field if description not empty

DDN field isn't required, no point in writing an empty string to it.

Change-Id: Ifea6e48c324598f114178e86a79f519ee35f5258
Signed-off-by: Matt DeVillier 
---
M src/drivers/i2c/generic/generic.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/47781/1

diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c
index cd74068..1c7267e 100644
--- a/src/drivers/i2c/generic/generic.c
+++ b/src/drivers/i2c/generic/generic.c
@@ -72,7 +72,8 @@
    if (config->cid)
    	acpigen_write_name_string("_CID", config->cid);
    acpigen_write_name_integer("_UID", config->uid);
-	acpigen_write_name_string("_DDN", config->desc);
+	if (config->desc)
+		acpigen_write_name_string("_DDN", config->desc);
    acpigen_write_STA(acpi_device_status(dev));

/* Resources */

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47781 )

Change subject: drivers/i2c/generic: Only write DDN field if description not empty
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47781 )

Change subject: drivers/i2c/generic: Only write DDN field if description not empty
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47781 )

Change subject: drivers/i2c/generic: Only write DDN field if description not empty
......................................................................

drivers/i2c/generic: Only write DDN field if description not empty

DDN field isn't required, no point in writing an empty string to it.

Change-Id: Ifea6e48c324598f114178e86a79f519ee35f5258
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47781
Reviewed-by: Furquan Shaikh 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/drivers/i2c/generic/generic.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c
index cd74068..1c7267e 100644
--- a/src/drivers/i2c/generic/generic.c
+++ b/src/drivers/i2c/generic/generic.c
@@ -72,7 +72,8 @@
    if (config->cid)
    	acpigen_write_name_string("_CID", config->cid);
    acpigen_write_name_integer("_UID", config->uid);
-	acpigen_write_name_string("_DDN", config->desc);
+	if (config->desc)
+		acpigen_write_name_string("_DDN", config->desc);
    acpigen_write_STA(acpi_device_status(dev));

/* Resources */