Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Shuo Liu, Tim Chu, Ziang Wang.
Paul Menzel has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/81443?usp=email )
Change subject: soc/intel/xeon_sp: Add PD_TYPE_CLUSTER
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81443/comment/faf91244_434db5dc?usp... :
PS6, Line 9: Add a new proximity type to represent the sub-NUMA
: cluster (SNC).
:
: This patch doesn't actually enable SNC. To fully enable
: SNC, SoC codes need to override soc_get_cluster_count(),
: soc_set_cpu_node_id() and memory_to_pd(), and call
: soc_set_cpu_node_id() in its per-CPU init routine.
Please re-flow for 72 characters per line.
File src/soc/intel/xeon_sp/spr/chip.c:
https://review.coreboot.org/c/coreboot/+/81443/comment/d44711ae_7eb3f5e1?usp... :
PS6, Line 178: if (pds.pds[i].pd_type != PD_TYPE_GENERIC_INITIATOR)
Excuse my ignorance, but could these hunks be explained in the commit message?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81443?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32558983780f302ff4893901540a90baebf47add
Gerrit-Change-Number: 81443
Gerrit-PatchSet: 6
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 22 May 2024 09:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No