Attention is currently required from: Michał Żygowski, Angel Pons, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59516 )
Change subject: security/intel/txt: Implement GETSEC PARAMETER dumping ......................................................................
Patch Set 5: Verified+1
(2 comments)
File src/security/intel/txt/logging.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134385): https://review.coreboot.org/c/coreboot/+/59516/comment/df8b95e4_f18ed4f3 PS5, Line 253: if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_CRTM_SUPPORT) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134385): https://review.coreboot.org/c/coreboot/+/59516/comment/1180d6b0_c96bb69a PS5, Line 259: if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK) { braces {} are not necessary for any arm of this statement