Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/25329
Change subject: ec/purism: Fix CPU Turbo value (PPCM) set by the EC ......................................................................
ec/purism: Fix CPU Turbo value (PPCM) set by the EC
The EC needs to set the PPCM value depending on whether Turbo is enabled or not, and the values differ between Broadwell (0, 1) and Skylake (1, 2) platforms.
Change-Id: I662dce54415e685c054ffc00b6afde0f1f7765e2 Signed-off-by: Youness Alaoui youness.alaoui@puri.sm --- M src/ec/purism/librem/acpi/ec.asl M src/mainboard/purism/librem13v1/acpi/ec.asl M src/mainboard/purism/librem_skl/acpi/ec.asl 3 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/25329/1
diff --git a/src/ec/purism/librem/acpi/ec.asl b/src/ec/purism/librem/acpi/ec.asl index e95f126..ff325aa 100644 --- a/src/ec/purism/librem/acpi/ec.asl +++ b/src/ec/purism/librem/acpi/ec.asl @@ -218,11 +218,11 @@ * when the system is charging. */ If (TURB) { - Store (Zero, PPCM) + Store (PPCM_TURBO, PPCM) PPCN () Store (One, EDTB) } Else { - Store (One, PPCM) + Store (PPCM_NOTURBO, PPCM) PPCN () Store (Zero, EDTB) } diff --git a/src/mainboard/purism/librem13v1/acpi/ec.asl b/src/mainboard/purism/librem13v1/acpi/ec.asl index cf8b9a9..b2fa5b9 100644 --- a/src/mainboard/purism/librem13v1/acpi/ec.asl +++ b/src/mainboard/purism/librem13v1/acpi/ec.asl @@ -14,5 +14,7 @@ */
#define EC_SCI_GPI 10 +#define PPCM_TURBO Zero +#define PPCM_NOTURBO One
#include <ec/purism/librem/acpi/ec.asl> diff --git a/src/mainboard/purism/librem_skl/acpi/ec.asl b/src/mainboard/purism/librem_skl/acpi/ec.asl index 4215213..c667b6c 100644 --- a/src/mainboard/purism/librem_skl/acpi/ec.asl +++ b/src/mainboard/purism/librem_skl/acpi/ec.asl @@ -14,5 +14,7 @@ */
#define EC_SCI_GPI 0x50 +#define PPCM_TURBO One +#define PPCM_NOTURBO 0x02
#include <ec/purism/librem/acpi/ec.asl>