[S] Change in coreboot[master]: mb/google/herobrine: Implement mainboard_needs_pcie_init - coreboot-gerrit

17 Nov 2022


      Attention is currently required from: Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69689 )
Change subject: mb/google/herobrine: Implement mainboard_needs_pcie_init
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/69689/comment/310763f3_f1c97ec6 
PS2, Line 104: 	if ((sku & BIT(0)) == 2)
...
Uhh... pretty sure this doesn't work...? […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8972424f0c5d082165c185ab52a638e8b134064c
Gerrit-Change-Number: 69689
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-CC: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-CC: Venkat Thogaru thogaru@qualcomm.corp-partner.google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Thu, 17 Nov 2022 02:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment