Attention is currently required from: Jason Glenesk, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69705 )
Change subject: mb/amd/birman/port_descriptors.c: Update DXIO for birman
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/amd/birman/port_descriptors.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163804):
https://review.coreboot.org/c/coreboot/+/69705/comment/42fe487e_9e806da6
PS1, Line 168: break;
break is not useful after a return
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76cf6715b60a1857bf58349d70a623bf043594fe
Gerrit-Change-Number: 69705
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 16 Nov 2022 18:18:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment