Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao, Karthik Ramasubramanian, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51025 )
Change subject: soc/amd/cezanne: Get I2C controller infomation
......................................................................
Patch Set 7:
(2 comments)
File src/soc/amd/cezanne/include/soc/i2c.h:
https://review.coreboot.org/c/coreboot/+/51025/comment/d259791e_51d765e6
PS6, Line 9: #define GPIO_I2C2_SCL BIT(2)
: #define GPIO_I2C3_SCL BIT(3)
yes, that should be added for i2c0 and i2c1 too, since those are usable from the x86 side on renoir/ […]
Done
File src/soc/amd/cezanne/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/51025/comment/eeea445c_6f4ac55d
PS6, Line 20: 2
this should be 0, since i2c0 and i2c1 are usable from the x86 side in cezanne
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51025
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic480681d4b7c6fb8591e729090e4faeb5fccf800
Gerrit-Change-Number: 51025
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 17 Mar 2021 09:12:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment