Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47650 )
Change subject: soc/amd/picasso: Remove unused psp_verstage spinlock.h ......................................................................
soc/amd/picasso: Remove unused psp_verstage spinlock.h
This file is no longer needed since the code that relied on it has been removed.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I4bc227e20e102b715961ee09bf1a0a87bf382ecf --- D src/soc/amd/picasso/psp_verstage/include/arch/smp/spinlock.h 1 file changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/47650/1
diff --git a/src/soc/amd/picasso/psp_verstage/include/arch/smp/spinlock.h b/src/soc/amd/picasso/psp_verstage/include/arch/smp/spinlock.h deleted file mode 100644 index 0a3a4d4..0000000 --- a/src/soc/amd/picasso/psp_verstage/include/arch/smp/spinlock.h +++ /dev/null @@ -1,15 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef _ARCH_SMP_SPINLOCK_H -#define _ARCH_SMP_SPINLOCK_H - -#define DECLARE_SPIN_LOCK(x) -#define spin_is_locked(lock) 0 -#define spin_unlock_wait(lock) do {} while (0) -#define spin_lock(lock) do {} while (0) -#define spin_unlock(lock) do {} while (0) - -#include <smp/node.h> -#define boot_cpu() 1 - -#endif
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47650 )
Change subject: soc/amd/picasso: Remove unused psp_verstage spinlock.h ......................................................................
Patch Set 1:
Thanks, looks like this reverts CB:43310 whose fast-tracking I previously had objected.
Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47650 )
Change subject: soc/amd/picasso: Remove unused psp_verstage spinlock.h ......................................................................
Abandoned
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47650 )
Change subject: soc/amd/picasso: Remove unused psp_verstage spinlock.h ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Why was this abandoned (without reasoning) again?
Like I commented in fast-tracked CB:43310 there is some asymmetry with spinlock.h includes and case of CONFIG(SMP) evaluating incorrectly when stages run on different arch.
-
Kyösti Mälkki (Code Review) -
Martin Roth (Code Review)