Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Aaron Durbin, Felix Held.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50379 )
Change subject: src: Add missing <cbmem.h>
......................................................................
Patch Set 1:
(3 comments)
File src/include/imd_private.h:
https://review.coreboot.org/c/coreboot/+/50379/comment/1000f27a_4bf664c9
PS1, Line 34: CBMEM_ID_IMD_SMALL
needs <commonlib/cbmem_id.h> through <cbmem.h>
File src/security/vboot/vboot_loader.c:
https://review.coreboot.org/c/coreboot/+/50379/comment/af1868e7_89360f3f
PS1, Line 95: CBMEM_ID_CBFS_RW_MCACHE
needs <commonlib/cbmem_id.h> through <cbmem.h>
File src/soc/amd/common/block/pi/refcode_loader.c:
https://review.coreboot.org/c/coreboot/+/50379/comment/a648b4bc_4b45001b
PS1, Line 47: CBMEM_ID_REFCODE
needs <commonlib/cbmem_id.h> through <cbmem.h>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75a816c594b326df8a4aa5458bb055fca35e1741
Gerrit-Change-Number: 50379
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 08 Feb 2021 09:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment