Change in ...coreboot[master]: util/sconfig: Move 'static' at beginning of declaration

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32900

Change subject: util/sconfig: Move 'static' at beginning of declaration
......................................................................

util/sconfig: Move 'static' at beginning of declaration

When using -Werror=old-style-declaration, gcc reports an error:
"'static' is not at beginning of declaration"

Tested on 945G-M4 board.

Change-Id: I7216a4fab2d5878066c871166e6a481d1f201a9d
Signed-off-by: Elyes HAOUAS 
---
M util/sconfig/main.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/32900/1

diff --git a/util/sconfig/main.c b/util/sconfig/main.c
index c3aa17f..548063f 100644
--- a/util/sconfig/main.c
+++ b/util/sconfig/main.c
@@ -701,7 +701,7 @@
    	return;
    }

-	fprintf(fil, "DEVTREE_CONST static struct device %s;\n", ptr->name);
+	fprintf(fil, "static DEVTREE_CONST struct device %s;\n", ptr->name);
    if (ptr->res)
    	fprintf(fil, "DEVTREE_CONST struct resource %s_res[];\n",
    		ptr->name);

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32900 )

Change subject: util/sconfig: Move 'static' at beginning of declaration
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32900 )

Change subject: util/sconfig: Move 'static' at beginning of declaration
......................................................................

Patch Set 1: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32900 )

Change subject: util/sconfig: Move 'static' at beginning of declaration
......................................................................

util/sconfig: Move 'static' at beginning of declaration

When using -Werror=old-style-declaration, gcc reports an error:
"'static' is not at beginning of declaration"

Tested on 945G-M4 board.

Change-Id: I7216a4fab2d5878066c871166e6a481d1f201a9d
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32900
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
Reviewed-by: Paul Menzel 
---
M util/sconfig/main.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/util/sconfig/main.c b/util/sconfig/main.c
index c3aa17f..548063f 100644
--- a/util/sconfig/main.c
+++ b/util/sconfig/main.c
@@ -701,7 +701,7 @@
    	return;
    }

-	fprintf(fil, "DEVTREE_CONST static struct device %s;\n", ptr->name);
+	fprintf(fil, "static DEVTREE_CONST struct device %s;\n", ptr->name);
    if (ptr->res)
    	fprintf(fil, "DEVTREE_CONST struct resource %s_res[];\n",
    		ptr->name);