Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59634 )
Change subject: acpi: Convert ACPI_DEVICE_SLEEP_* values to an enum ......................................................................
acpi: Convert ACPI_DEVICE_SLEEP_* values to an enum
These values make more sense as an enum, and are currently unused in ASL files, therefore they can be moved to the appropriate part of the header file and converted there.
Change-Id: I8b8586b46823b5da3614a0b2a2f2f16802e96962 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/59634 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/include/acpi/acpi.h 1 file changed, 9 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 4a95855..dade92d 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -31,14 +31,6 @@ #define SLP_TYP_S5 5 #endif
-/* ACPI Device Sleep States */ -#define ACPI_DEVICE_SLEEP_D0 0 -#define ACPI_DEVICE_SLEEP_D1 1 -#define ACPI_DEVICE_SLEEP_D2 2 -#define ACPI_DEVICE_SLEEP_D3 3 -#define ACPI_DEVICE_SLEEP_D3_HOT ACPI_DEVICE_SLEEP_D3 -#define ACPI_DEVICE_SLEEP_D3_COLD 4 - #define ACPI_TABLE_CREATOR "COREBOOT" /* Must be exactly 8 bytes long! */ #define OEM_ID "COREv4" /* Must be exactly 6 bytes long! */ #define ACPI_DSDT_REV_1 0x01 /* DSDT revision: ACPI v1 */ @@ -52,6 +44,15 @@ #include <romstage_handoff.h> #include <types.h>
+enum acpi_device_sleep_states { + ACPI_DEVICE_SLEEP_D0 = 0, + ACPI_DEVICE_SLEEP_D1 = 1, + ACPI_DEVICE_SLEEP_D2 = 2, + ACPI_DEVICE_SLEEP_D3 = 3, + ACPI_DEVICE_SLEEP_D3_HOT = ACPI_DEVICE_SLEEP_D3, + ACPI_DEVICE_SLEEP_D3_COLD = 4, +}; + #define RSDP_SIG "RSD PTR " /* RSDT pointer signature */ #define ASLC "CORE" /* Must be exactly 4 bytes long! */