Change in coreboot[master]: emulation/qemu-i440fx/northbridge.c: Fix minor whitespace

[Name of user not set (Code Review)]

Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35311 )

Change subject: emulation/qemu-i440fx/northbridge.c: Fix minor whitespace
......................................................................

emulation/qemu-i440fx/northbridge.c: Fix minor whitespace

Change-Id: Ifc3825119c8463a7d17a5c162330f49612ae1b85
Signed-off-by: Himanshu Sahdev 
---
M src/mainboard/emulation/qemu-i440fx/northbridge.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/35311/1

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c
index 852800d..0bff4d7 100644
--- a/src/mainboard/emulation/qemu-i440fx/northbridge.c
+++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c
@@ -72,7 +72,7 @@
    	for (i = 0; i < f.size / sizeof(*list); i++) {
    		switch (list[i].type) {
    		case 1: /* RAM */
-				printk(BIOS_DEBUG, "QEMU: e820/ram: 0x%08llx +0x%08llx\n",
+				printk(BIOS_DEBUG, "QEMU: e820/ram: 0x%08llx + 0x%08llx\n",
    			       list[i].address, list[i].length);
    			if (list[i].address == 0) {
    				tomk = list[i].length / 1024;

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35311 )

Change subject: emulation/qemu-i440fx/northbridge.c: Fix minor whitespace
......................................................................

Patch Set 1:

Does this _need_ to be corrected?

[Name of user not set (Code Review)]

Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35311 )

Change subject: emulation/qemu-i440fx/northbridge.c: Fix minor whitespace
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Does this _need_ to be corrected?

Thanks for your concern!
While debugging, observed this in log "QEMU: e820/ram: 0x00000000 +0x08000000".
It seems moreover like a positive value and not the length being added into the address in reference.

Do refer this as well CB:35265 
IMHO, it would be better for readability purpose.

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35311 )

Change subject: emulation/qemu-i440fx/northbridge.c: Fix minor whitespace
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35311 )

Change subject: emulation/qemu-i440fx/northbridge.c: Fix minor whitespace
......................................................................

emulation/qemu-i440fx/northbridge.c: Fix minor whitespace

Change-Id: Ifc3825119c8463a7d17a5c162330f49612ae1b85
Signed-off-by: Himanshu Sahdev 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35311
Tested-by: build bot (Jenkins) 
Reviewed-by: Martin Roth 
---
M src/mainboard/emulation/qemu-i440fx/northbridge.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c
index 852800d..0bff4d7 100644
--- a/src/mainboard/emulation/qemu-i440fx/northbridge.c
+++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c
@@ -72,7 +72,7 @@
    	for (i = 0; i < f.size / sizeof(*list); i++) {
    		switch (list[i].type) {
    		case 1: /* RAM */
-				printk(BIOS_DEBUG, "QEMU: e820/ram: 0x%08llx +0x%08llx\n",
+				printk(BIOS_DEBUG, "QEMU: e820/ram: 0x%08llx + 0x%08llx\n",
    			       list[i].address, list[i].length);
    			if (list[i].address == 0) {
    				tomk = list[i].length / 1024;