Attention is currently required from: Felix Singer, Maciej Pijanowski, Michał Żygowski, Piotr Król.
Felix Held has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/80501?usp=email )
Change subject: mb/protectli/vault_adl_p: Add initial support for VP6630/VP6650/VP6670 ......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/protectli/vault_adl_p/Kconfig:
https://review.coreboot.org/c/coreboot/+/80501/comment/6bb808c3_3ca1bf82?usp... : PS10, Line 26: config MAINBOARD_VENDOR : default "Protectli" this is already set in mainboard/protectli/Kconfig, so it's not needed in here. since it doesn't cause any malfunction and the other protectly mainboard i looked at also has this in the mainboard-specific Kconfig, i'd just say that it would be good if you can address this in a follow-up
File src/mainboard/protectli/vault_adl_p/bootblock.c:
https://review.coreboot.org/c/coreboot/+/80501/comment/ed482eb0_0bb2300d?usp... : PS10, Line 19: static void ite_set_gpio_iobase(u16 iobase) i wonder if this is code that would be common to the ite sio and if it should be moved there in a follow-up