Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30500 )
Change subject: arch/x86/postcar: Add x86_64 support ......................................................................
Patch Set 25: Code-Review+1
(1 comment)
Patch Set 25:
Patch Set 25:
What's the status of this patchset?
The whole patch chain waits for review and testing. As there was no feedback in month I dropped the interest in this. It was successfully tested on QEMU and Intel Nehalem platforms, so it's definitely working on blob free platforms.
With the patches you have landed, is it possible to enable paging on x86_32? Would be nice to have it to catch stack overflows or writes to random sections of memory.
https://review.coreboot.org/c/coreboot/+/30500/25/src/arch/x86/exit_car.S File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/30500/25/src/arch/x86/exit_car.S@39 PS25, Line 39: edx_eax Can you swap the edx and eax in the name so it reads like the operations are executing.
-
Raul Rangel (Code Review)