Change in coreboot[master]: mb/google/arcada: Enable bayhub 720 on Arcada

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Mark Hsieh (Code Review)

21 Jul 2020 21 Jul '20

12:49 p.m.

Mark Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

mb/google/arcada: Enable bayhub 720 on Arcada

Add PCIe-eMMC bridge bayhub 720 on Arcada to the devicetree.

BUG=b:157971972 BRANCH=master TEST=local build and boot from SATA/PCIe-eMMC storage successfully

Signed-off-by: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/43669/1

diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index a84e73a..71c5266 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -382,6 +382,10 @@ device pci 1d.2 on end # PCI Express Port 11 device pci 1d.3 off end # PCI Express Port 12 device pci 1d.4 on + chip drivers/generic/bayhub + register "power_saving" = "1" + device pci 00.0 on end + end smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "2280" "SlotDataBusWidth4X" end # PCI Express Port 13 (x4) device pci 1e.0 off end # UART #0

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Mathew King (Code Review)

21 Jul 21 Jul

4:58 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43669/1/src/mainboard/google/sarien... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43669/1/src/mainboard/google/sarien... PS1, Line 385: chip drivers/generic/bayhub : register "power_saving" = "1" : device pci 00.0 on end : end Please fix indentation.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Tue, 21 Jul 2020 14:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mark Hsieh (Code Review)

22 Jul 22 Jul

3:09 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Furquan Shaikh, Mathew King, Duncan Laurie,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43669

to look at the new patch set (#2).

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

mb/google/arcada: Enable bayhub 720 on Arcada

Add PCIe-eMMC bridge bayhub 720 on Arcada to the devicetree.

BUG=b:157971972 BRANCH=master TEST=local build and boot from SATA/PCIe-eMMC storage successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/43669/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 2 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Mark Hsieh (Code Review)

3:12 a.m.

Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43669/1/src/mainboard/google/sarien... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43669/1/src/mainboard/google/sarien... PS1, Line 385: chip drivers/generic/bayhub : register "power_saving" = "1" : device pci 00.0 on end : end

...

Please fix indentation.

Updated

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 2 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Wed, 22 Jul 2020 01:12:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King mathewk@chromium.org Gerrit-MessageType: comment

Mathew King (Code Review)

5:59 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43669/2/src/mainboard/google/sarien... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43669/2/src/mainboard/google/sarien... PS2, Line 386: register "power_saving" = "1" : device pci 00.0 on end Nit: these two lines should be indented one more level

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 2 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Wed, 22 Jul 2020 15:59:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mark Hsieh (Code Review)

23 Jul 23 Jul

3:13 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Furquan Shaikh, Mathew King, Duncan Laurie,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43669

to look at the new patch set (#3).

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

mb/google/arcada: Enable bayhub 720 on Arcada

Add PCIe-eMMC bridge bayhub 720 on Arcada to the devicetree.

BUG=b:157971972 BRANCH=master TEST=local build and boot from SATA/PCIe-eMMC storage successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/43669/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Mark Hsieh (Code Review)

3:13 a.m.

Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43669/2/src/mainboard/google/sarien... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43669/2/src/mainboard/google/sarien... PS2, Line 386: register "power_saving" = "1" : device pci 00.0 on end

...

Nit: these two lines should be indented one more level

Updated.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Thu, 23 Jul 2020 01:13:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King mathewk@chromium.org Gerrit-MessageType: comment

Mathew King (Code Review)

6:31 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Thu, 23 Jul 2020 16:31:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mathew King (Code Review)

6:31 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43669/1/src/mainboard/google/sarien... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43669/1/src/mainboard/google/sarien... PS1, Line 385: chip drivers/generic/bayhub : register "power_saving" = "1" : device pci 00.0 on end : end

...

Updated

Done

https://review.coreboot.org/c/coreboot/+/43669/2/src/mainboard/google/sarien... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43669/2/src/mainboard/google/sarien... PS2, Line 386: register "power_saving" = "1" : device pci 00.0 on end

...

Updated.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Thu, 23 Jul 2020 16:31:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King mathewk@chromium.org Comment-In-Reply-To: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-MessageType: comment

Mathew King (Code Review)

6:33 p.m.

Mathew King has uploaded a new patch set (#4) to the change originally created by Mark Hsieh. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

mb/google/arcada: Enable bayhub 720 on Arcada

Add PCIe-eMMC bridge bayhub 720 on Arcada to the devicetree.

BUG=b:157971972 BRANCH=sarien TEST=local build and boot from SATA/PCIe-eMMC storage successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/43669/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 4 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

7:06 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 4 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Thu, 23 Jul 2020 17:06:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:06 p.m.

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43669 )

Change subject: mb/google/arcada: Enable bayhub 720 on Arcada ......................................................................

mb/google/arcada: Enable bayhub 720 on Arcada

Add PCIe-eMMC bridge bayhub 720 on Arcada to the devicetree.

BUG=b:157971972 BRANCH=sarien TEST=local build and boot from SATA/PCIe-eMMC storage successfully

Signed-off-by: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Reviewed-on: https://review.coreboot.org/c/coreboot/+/43669 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Mathew King mathewk@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Mathew King: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index a84e73a..7e4da3f 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -382,6 +382,10 @@ device pci 1d.2 on end # PCI Express Port 11 device pci 1d.3 off end # PCI Express Port 12 device pci 1d.4 on + chip drivers/generic/bayhub + register "power_saving" = "1" + device pci 00.0 on end + end smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "2280" "SlotDataBusWidth4X" end # PCI Express Port 13 (x4) device pci 1e.0 off end # UART #0

-- To view, visit https://review.coreboot.org/c/coreboot/+/43669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e925730e57806e7398684dffd0d3bd1f4f9deeb Gerrit-Change-Number: 43669 Gerrit-PatchSet: 5 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: merged

1567

days inactive

1569

days old

coreboot-gerrit@coreboot.org

11 comments

3 participants

tags (0)

participants (3)

Mark Hsieh (Code Review)
Mathew King (Code Review)
Tim Wawrzynczak (Code Review)