Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23866 )
Change subject: soc/intel/skylake: Move PCR DMI programming into bootblock
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/skylake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/23866/comment/7b4e8969_e0103ea0
PS3, Line 186: if (pch_check_decode_enable() == 0) {
Secured Register Lock (SRL): […]
That a register can't be written when locked is clear, so far. But
why assume that the lock may already be set here in bootblock?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/23866
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie706735492a450baa653d8a8bb74c6e42f5150b8
Gerrit-Change-Number: 23866
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tung Lun Loo
tung.lun.loo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 24 Jan 2021 11:10:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment