Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin.
Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73176 )
Change subject: soc/mediatek: Add config to control DRAM scramble ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73176/comment/008e2d5d_6fff9128 PS2, Line 7: scramble config and pass it to dramk
config to control DRAM scramble
Done
https://review.coreboot.org/c/coreboot/+/73176/comment/7654d905_5c7c5131 PS2, Line 9: DRAM Scramble enhances DRAM data protection. If enable it, : DRAM data is not the written data, it's scrambled. To debug : feature which requires the same DRAM data after resetting, : must disable it.
The DRAM scramble feature enhances DRAM data protection. […]
Done
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/73176/comment/f387a884_f6818fda PS2, Line 87: config DRAM_SCRAMBLE
Move to line 32 and rename to `MEDIATEK_DRAM_SCRAMBLE` for consisteny.
Done
File src/soc/mediatek/common/include/soc/dramc_param_common.h:
https://review.coreboot.org/c/coreboot/+/73176/comment/8f4bb06e_5e631ad5 PS2, Line 35: 0x0100
Okay, then please change back to the original comment: `/* Security configs */` (note the `s`). […]
Done