Change in coreboot[master]: soc/amd/picasso: introduce and use chipset device tree - coreboot-gerrit

23 Feb 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50626 )
Change subject: soc/amd/picasso: introduce and use chipset device tree
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: 
How did you determine what to put into chipset.cb?  Devices that always need to be on?  I'm wondering about D14F3 too.
File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:
https://review.coreboot.org/c/coreboot/+/50626/comment/384f7530_ca8bc3cb 
PS4, Line 386: device pci 14.0 on  end # SM
Should this also come out?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50626
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b7c3fd32579a23539594672593a243172c161c7
Gerrit-Change-Number: 50626
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 23 Feb 2021 17:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment