EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40519 )
Change subject: mb/google/deltaur: Correct SPD SMBus address ......................................................................
mb/google/deltaur: Correct SPD SMBus address
SMBus use 7-bits address, change it from 8-bits to 7-bits.
BUG=b:151702387 TEST=Check Memory SPD data is correct in console log.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I1720b4d6aa0bc785ad86234b3523bb0676ec5c82 --- M src/mainboard/google/deltaur/variants/deltan/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/40519/1
diff --git a/src/mainboard/google/deltaur/variants/deltan/memory.c b/src/mainboard/google/deltaur/variants/deltan/memory.c index d51ba70..0c5873f 100644 --- a/src/mainboard/google/deltaur/variants/deltan/memory.c +++ b/src/mainboard/google/deltaur/variants/deltan/memory.c @@ -48,9 +48,9 @@ { const struct spd_info spd_info = { .topology = SODIMM, - .smbus_info[0] = {.addr_dimm0 = 0xa0, + .smbus_info[0] = {.addr_dimm0 = 0x50, .addr_dimm1 = 0 }, - .smbus_info[1] = {.addr_dimm0 = 0xa4, + .smbus_info[1] = {.addr_dimm0 = 0x52, .addr_dimm1 = 0 }, }; const bool half_populated = false;
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40519 )
Change subject: mb/google/deltaur: Correct SPD SMBus address ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40519/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40519/1//COMMIT_MSG@9 PS1, Line 9: use uses
Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Varun Joshi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40519
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Correct SPD SMBus address ......................................................................
mb/google/deltaur: Correct SPD SMBus address
SMBus uses 7-bits address, change it from 8-bits to 7-bits.
BUG=b:151702387 TEST=Check Memory SPD data is correct in console log.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I1720b4d6aa0bc785ad86234b3523bb0676ec5c82 --- M src/mainboard/google/deltaur/variants/deltan/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/40519/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40519 )
Change subject: mb/google/deltaur: Correct SPD SMBus address ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40519/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40519/1//COMMIT_MSG@9 PS1, Line 9: use
uses
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40519 )
Change subject: mb/google/deltaur: Correct SPD SMBus address ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40519 )
Change subject: mb/google/deltaur: Correct SPD SMBus address ......................................................................
mb/google/deltaur: Correct SPD SMBus address
SMBus uses 7-bits address, change it from 8-bits to 7-bits.
BUG=b:151702387 TEST=Check Memory SPD data is correct in console log.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I1720b4d6aa0bc785ad86234b3523bb0676ec5c82 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40519 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/google/deltaur/variants/deltan/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/variants/deltan/memory.c b/src/mainboard/google/deltaur/variants/deltan/memory.c index d51ba70..0c5873f 100644 --- a/src/mainboard/google/deltaur/variants/deltan/memory.c +++ b/src/mainboard/google/deltaur/variants/deltan/memory.c @@ -48,9 +48,9 @@ { const struct spd_info spd_info = { .topology = SODIMM, - .smbus_info[0] = {.addr_dimm0 = 0xa0, + .smbus_info[0] = {.addr_dimm0 = 0x50, .addr_dimm1 = 0 }, - .smbus_info[1] = {.addr_dimm0 = 0xa4, + .smbus_info[1] = {.addr_dimm0 = 0x52, .addr_dimm1 = 0 }, }; const bool half_populated = false;
-
EricR Lai (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)