Attention is currently required from: Nico Huber, Jonathan Zhang, Paul Menzel, David Hendricks, Rocky Phagura, Aaron Durbin. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52518 )
Change subject: src/cpu/x86/smm: remove debug message; not thread safe ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52518/comment/b8e03e16_2d13e7b2 PS2, Line 10: This prevents system hangs (soft hangs) : while in SMM if user drops in a new SOC with more cores or another : socket.
Yes. The intention of the message is for a developer to know they have a bad configuration. It's definitely the exceptional case. If people want to remove it, I don't have a strong opinion. However, that was the original point -- help out development when Kconfig settings are off compared to runtime.
With the smm_module_loader.c (v1) the cpu stacks were placed above the permanent handler code. With v2 the stacks are placed below the stubs (and the permanent handler). V1 was dropped for V2 in the master branch. So worse things now likely happen with a not-accounted for CPU... BTW the smm relocation code already checks for cpu > CONFIG_MAX_CPUS.
-
Arthur Heymans (Code Review)