Attention is currently required from: Jérémy Compostella, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84718?usp=email )
Change subject: mb/google/fatcat: add pre-mem configuration based on fw_config ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84718/comment/f33483c6_0d34c806?usp... : PS4, Line 7: dd pre-mem GPIO pad configure based on fw_config
I am confused, we followed https://review.coreboot. […]
commit messages changed.
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/84718/comment/98b43759_09de93f0?usp... : PS4, Line 19: NOTE:
can you please move this into next line ?
Done
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84718/comment/c66f6c47_74e02bd5?usp... : PS4, Line 108: device ref pcie_rp2 on : probe CELLULAR CELLULAR_PCIE : register "pcie_rp[PCIE_RP(2)]" = "{ : .clk_src = 5, : .clk_req = 5, : .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER, : }" : end # WWAN
looks like you need to add RTD3 and WWAN driver entries […]
Done. also need to add WWAN driver in MB Kconfig.