Attention is currently required from: Felix Singer, Michał Kopeć, Stefan Reinauer, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63374 )
Change subject: util/inteltool: Add support for Alder Lake chips detection and GPIOs ......................................................................
Patch Set 8:
(9 comments)
File util/inteltool/gpio_names/alderlake_h.h:
https://review.coreboot.org/c/coreboot/+/63374/comment/0ecf82ce_4d843667 PS8, Line 102: const char *const alderlake_pch_h_group_d_names[] = { The DOC #618659 has copy-pasta error, the NF6 column should obviously contain: `USB_C_GPP_Dx` not `USB_C_GPP_Cx`
https://review.coreboot.org/c/coreboot/+/63374/comment/4ca34220_87d2ffdb PS8, Line 437: &alderlake_pch_h_group_j, In the coreboot tree we add vgpios, for completeness we should add them here as well
https://review.coreboot.org/c/coreboot/+/63374/comment/76f56091_e23e05c3 PS8, Line 473: &alderlake_pch_h_group_c, vpgio3 missing
https://review.coreboot.org/c/coreboot/+/63374/comment/d82e1759_f070a9d6 PS8, Line 498: &alderlake_pch_h_group_d, jtag and cpu gorups missing
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/63374/comment/ae852334_aa3359b1 PS8, Line 356: #define PCI_DEVICE_ID_INTEL_CORE_ADL_ID_H_6_8 0x4641 /* Alderlake H 6+8 */ This is H processor line, different from S and HX line which the dump/patch is for.
https://review.coreboot.org/c/coreboot/+/63374/comment/0f572e35_6c456363 PS8, Line 436: #define PCI_DEVICE_ID_INTEL_ADL_S_GT1 0x4680 There are more IDs based on the stepping for S LGA and HX SBGA
https://review.coreboot.org/c/coreboot/+/63374/comment/a53b9335_60ac1853 PS8, Line 437: #define PCI_DEVICE_ID_INTEL_ADL_P_GT2 0x46a0 : #define PCI_DEVICE_ID_INTEL_ADL_M_GT1 0x46c0 Not an ADL-S/HX GT devices
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/63374/comment/b08069fd_08986eeb PS8, Line 173: { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_ADL_ID_H_6_8, : "12th generation (Alder Lake H family) Core Processor (Mobile)" }, Not an ADL-S/HX line
https://review.coreboot.org/c/coreboot/+/63374/comment/19a54b3c_cc0a9e3e PS8, Line 545: { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ADL_P_GT2, : "Intel(R) AlderLake-P GT2" }, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ADL_M_GT1, : "Intel(R) AlderLake-M GT1" }, Not an ADL-S/HX GT devices