Attention is currently required from: Kedar J. Karanje, Furquan Shaikh, Tim Wawrzynczak, Sridhar Siricilla, Subrata Banik, Vinay Kumar, Ronak Kanabar, Patrick Rudolph, Baieswara Reddy Sagili.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56176 )
Change subject: soc/intel/alderlake: Update the VccIn Aux Imon IccMax for ADL
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/56176/comment/8c3d883b_189a704a
PS4, Line 294: PCI_DEVICE_ID_INTEL_ADL_P_ID_3
I think this function should handle all the SKUs known to coreboot rather than just configuring the […]
@furquan,
I updated the details on how these configurations are generated and also created a crossbug for the further discussion-> https://partnerissuetracker.corp.google.com/issues/195033556.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c159035cba781d3661a0a0cef16f9591a583912
Gerrit-Change-Number: 56176
Gerrit-PatchSet: 8
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Reviewer: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Comment-Date: Thu, 29 Jul 2021 21:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: V Sowmya
v.sowmya@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment