Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47103 )
Change subject: util/sconfig: Report which key is duplicate ......................................................................
util/sconfig: Report which key is duplicate
It slightly helps debugging issues when you know what to look out for.
Change-Id: I21eafaf8291701316aa920e458ba74535121b0a1 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/sconfig/main.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/47103/1
diff --git a/util/sconfig/main.c b/util/sconfig/main.c index a7b2ce6..1fd4404 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -872,7 +872,7 @@ for (cur = *head; cur != NULL; prev = cur, cur = cur->next) { const int sort = strcmp(r->key, cur->key); if (sort == 0) { - printf("ERROR: duplicate 'register' key.\n"); + printf("ERROR: duplicate 'register' key '%s'.\n", r->key); exit(1); } if (sort < 0)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47103 )
Change subject: util/sconfig: Report which key is duplicate ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47103 )
Change subject: util/sconfig: Report which key is duplicate ......................................................................
Patch Set 2: Code-Review+2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47103 )
Change subject: util/sconfig: Report which key is duplicate ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47103 )
Change subject: util/sconfig: Report which key is duplicate ......................................................................
util/sconfig: Report which key is duplicate
It slightly helps debugging issues when you know what to look out for.
Change-Id: I21eafaf8291701316aa920e458ba74535121b0a1 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47103 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/sconfig/main.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Martin Roth: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/sconfig/main.c b/util/sconfig/main.c index a7b2ce6..1fd4404 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -872,7 +872,7 @@ for (cur = *head; cur != NULL; prev = cur, cur = cur->next) { const int sort = strcmp(r->key, cur->key); if (sort == 0) { - printf("ERROR: duplicate 'register' key.\n"); + printf("ERROR: duplicate 'register' key '%s'.\n", r->key); exit(1); } if (sort < 0)
-
Angel Pons (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)