Change in coreboot[master]: mb/emulate/qemu-aarch64: Add a timestamp region

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Arthur Heymans (Code Review)

2 Nov 2020 2 Nov '20

8:39 p.m.

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47105 )

Change subject: mb/emulate/qemu-aarch64: Add a timestamp region ......................................................................

mb/emulate/qemu-aarch64: Add a timestamp region

The romstage region is moved up a bit more to satisfy the MMU.

Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/emulation/qemu-aarch64/memlayout.ld 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/47105/1

diff --git a/src/mainboard/emulation/qemu-aarch64/memlayout.ld b/src/mainboard/emulation/qemu-aarch64/memlayout.ld index f739ddf..cee77cd 100644 --- a/src/mainboard/emulation/qemu-aarch64/memlayout.ld +++ b/src/mainboard/emulation/qemu-aarch64/memlayout.ld @@ -21,7 +21,8 @@ BOOTBLOCK(0x60010000, 64K) STACK(0x60020000, 62K) FMAP_CACHE(0x6002F800, 2K) - ROMSTAGE(0x60030000, 128K) + TIMESTAMP(0x60030000, 1K) + ROMSTAGE(0x60031000, 128K) TTB(0x60070000, 128K) RAMSTAGE(0x600b0000, 16M)

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Angel Pons (Code Review)

2 Nov 2 Nov

8:44 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47105 )

Change subject: mb/emulate/qemu-aarch64: Add a timestamp region ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/47105/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47105/1//COMMIT_MSG@7 PS1, Line 7: emulate "emulation"?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Gerrit-Change-Number: 47105 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Comment-Date: Mon, 02 Nov 2020 20:44:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

8:45 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47105 )

Change subject: mb/emulate/qemu-aarch64: Add a timestamp region ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Gerrit-Change-Number: 47105 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 02 Nov 2020 20:45:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

8:49 p.m.

New subject: Change in coreboot[master]: mb/emulation/qemu-aarch64: Add a timestamp region

Hello build bot (Jenkins), Patrick Rudolph, Angel Pons, Julius Werner, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47105

to look at the new patch set (#2).

Change subject: mb/emulation/qemu-aarch64: Add a timestamp region ......................................................................

mb/emulation/qemu-aarch64: Add a timestamp region

The romstage region is moved up a bit more to satisfy the MMU.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/47105/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Gerrit-Change-Number: 47105 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

9:01 p.m.

New subject: Change in coreboot[master]: mb/emulation/qemu-aarch64: Add a timestamp region

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47105 )

Change subject: mb/emulation/qemu-aarch64: Add a timestamp region ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Gerrit-Change-Number: 47105 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 02 Nov 2020 21:01:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

9:01 p.m.

New subject: Change in coreboot[master]: mb/emulation/qemu-aarch64: Add a timestamp region

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47105 )

Change subject: mb/emulation/qemu-aarch64: Add a timestamp region ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47105/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47105/1//COMMIT_MSG@7 PS1, Line 7: emulate

...

"emulation"?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Gerrit-Change-Number: 47105 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 02 Nov 2020 21:01:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Christian Walter (Code Review)

9:45 p.m.

New subject: Change in coreboot[master]: mb/emulation/qemu-aarch64: Add a timestamp region

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47105 )

Change subject: mb/emulation/qemu-aarch64: Add a timestamp region ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Gerrit-Change-Number: 47105 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 02 Nov 2020 21:45:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4 Nov 4 Nov

9:38 a.m.

New subject: Change in coreboot[master]: mb/emulation/qemu-aarch64: Add a timestamp region

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47105 )

Change subject: mb/emulation/qemu-aarch64: Add a timestamp region ......................................................................

mb/emulation/qemu-aarch64: Add a timestamp region

The romstage region is moved up a bit more to satisfy the MMU.

Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/47105 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/emulation/qemu-aarch64/memlayout.ld 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, approved Christian Walter: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/47105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c2b4972495fa669d4dc2a52f298a0e4d0cf5ff Gerrit-Change-Number: 47105 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1291

days inactive

1293

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Christian Walter (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)