Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46018 )
Change subject: soc/intel/*: conversion from constant to Kconfig for XTAL frequency
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46018/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46018/8//COMMIT_MSG@9
PS8, Line 9: This converts the constant for the XTAL frequency to a Kconfig option.
The value depends on the soc. No device should override this and thus, it's not a devicetree option.
Oh btw. this was done first to make the buildbot pass for socs without that value defined. By moving the emulation code to it's own compilation unit, this is not required anymore.
However, it feels right to do so. I'd be ok with dropping that change, though, if all agree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46018
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1382dd274eeb9cb748f94c34f5d9a83880624c18
Gerrit-Change-Number: 46018
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Oct 2020 09:42:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment