Change in coreboot[master]: soc/intel: Allow enable/disable ME via CMOS - coreboot-gerrit

3 Jun 2021


      Attention is currently required from: Andy Pont, Tim Wawrzynczak, Paul Menzel, Arthur Heymans, Patrick Rudolph.
Star Labs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )
Change subject: soc/intel: Allow enable/disable ME via CMOS
......................................................................
Patch Set 21:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/52800/comment/dd9e7aaf_c51113e0 
PS20, Line 103: 	struct enable_command {
              : 		struct mkhi_hdr hdr;
              : 	} __packed;
...
what is there to pack ?
Fair point!
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20
Gerrit-Change-Number: 52800
Gerrit-PatchSet: 21
Gerrit-Owner: Star Labs admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Andy Pont andy.pont@sdcsystems.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Andy Pont andy.pont@sdcsystems.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 03 Jun 2021 06:34:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment