Attention is currently required from: Angel Pons, Arthur Heymans, Simon Glass.
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79079?usp=email )
Change subject: Disable separate romstage for emulation builds
......................................................................
Patch Set 3:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/79079/comment/db652a60_9ad8433f :
PS3, Line 248: default y if !VENDOR_EMULATION
Can you override the default value for `SEPARATE_ROMSTAGE` from `src/mainboard/emulation/` instead? […]
Do you know how to do that? So far as I can tell a 'default n' does not override a 'default y' but perhaps it depends on the ordering/
This is what I tried in src/mainboard/emulation/Kconfig :
config SEPARATE_ROMSTAGE
default n
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79079?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4fa8322dba9b5a46c5a73489cb396199621e068
Gerrit-Change-Number: 79079
Gerrit-PatchSet: 3
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Simon Glass
sjg@chromium.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Comment-Date: Wed, 29 Nov 2023 21:43:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment