Attention is currently required from: Jason Glenesk.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47727 )
Change subject: soc/amd/picasso: Generate ACPI CRAT objects in cb
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
I have a few ideas for follow-on changes but I think this is pretty close right now.
File src/soc/amd/picasso/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/47727/comment/151dca6a_54717c79
PS4, Line 598: (*cache_affinity)->length = sizeof(struct crat_cache);
Remove duplicate. Or was this a copy/paste/modify problem and something's missing?
https://review.coreboot.org/c/coreboot/+/47727/comment/76ed7453_139d305b
PS4, Line 1028: printk(BIOS_DEBUG, "Searching for AGESA FSP ACPI Tables\n");
Nit, this comment is out of place now, however it's mostly outlived its usefulness.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47727
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If64fd624597b2ced014ba7f0332a6a48143c0e8c
Gerrit-Change-Number: 47727
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 17:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment