Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52674 )
Change subject: soc/amd/common/smi_handler: Print warning when receiving an SCI SMI
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52674/comment/3e069559_f744198d
PS1, Line 10: just silently ignoring the, print a warning saying that it is being
"ignoring the SMI"?
File src/soc/amd/common/block/cpu/smm/smi_handler.c:
https://review.coreboot.org/c/coreboot/+/52674/comment/bfe30fb4_0b4b9461
PS1, Line 39: printk(BIOS_WARNING, "Ignoring SCI SMI: %#x\n", smi_read32(SMI_SCI_STATUS));
do you want something a bit more aggressive like an ERROR here? Would we ever find out source of the interrupt if we didn't block on it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I803e572250925b7d5ffdbb3e8958f9aff1f808df
Gerrit-Change-Number: 52674
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 26 Apr 2021 19:12:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment