Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71283 )
Change subject: Revert "mb/starlabs/starbook/adl: Enable the PchHdaAudioLinkHdaEnable UPD" ......................................................................
Revert "mb/starlabs/starbook/adl: Enable the PchHdaAudioLinkHdaEnable UPD"
This reverts commit 0e945a3426782e3c054a920ff8be3cd865f697ba.
Reason for revert: Breaks build. Need to be merged after https://review.coreboot.org/c/coreboot/+/71715 which adds the register that this patch enables
Signed-off-by: Martin L Roth gaumless@gmail.com Change-Id: I0ac3fb1a44e23e19c9711287f3a6a8402a6ffd79 Reviewed-on: https://review.coreboot.org/c/coreboot/+/71283 Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Elyes Haouas ehaouas@noos.fr --- M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb 1 file changed, 24 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Elyes Haouas: Looks good to me, approved Felix Singer: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 5e2bb1e..fba073d 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -167,10 +167,9 @@ end device ref p2sb on end device ref hda on - register "pch_hda_audio_link_hda_enable" = "1" - register "pch_hda_idisp_codec_enable" = "1" - register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ" - register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T" + register "pch_hda_idisp_codec_enable" = "1" + register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ" + register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T" end device ref smbus on end end