HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33680
Change subject: src/cpu: Use 'include <stdlib.h>' when appropriate ......................................................................
src/cpu: Use 'include <stdlib.h>' when appropriate
Also add some missing includes spotted by Jenkins
Change-Id: I7bd999b59d1c0bdfa5999bf5805576f94c9a2390 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/family_10h-family_15h/fidvid.c M src/cpu/amd/family_10h-family_15h/processor_name.c M src/cpu/x86/lapic/lapic_cpu_init.c M src/cpu/x86/mirror_payload.c 4 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/33680/1
diff --git a/src/cpu/amd/family_10h-family_15h/fidvid.c b/src/cpu/amd/family_10h-family_15h/fidvid.c index c5d523a..95985cd 100644 --- a/src/cpu/amd/family_10h-family_15h/fidvid.c +++ b/src/cpu/amd/family_10h-family_15h/fidvid.c @@ -94,6 +94,7 @@ #include <device/pci_ops.h> #include <inttypes.h> #include <northbridge/amd/amdht/AsPsDefs.h> +#include <stdlib.h>
static inline void print_debug_fv(const char *str, u32 val) { diff --git a/src/cpu/amd/family_10h-family_15h/processor_name.c b/src/cpu/amd/family_10h-family_15h/processor_name.c index 5672efd..ac0b57f 100644 --- a/src/cpu/amd/family_10h-family_15h/processor_name.c +++ b/src/cpu/amd/family_10h-family_15h/processor_name.c @@ -32,6 +32,8 @@ #include <device/pci.h> #include <device/pnp.h> #include <device/pci_ops.h> +#include <stddef.h> +#include <stdlib.h>
/* The maximum length of CPU names is 48 bytes, including the final NULL byte. * If you change these names your BIOS will _NOT_ pass the AMD validation and diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index 0f73e71..e1908d8 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -34,6 +34,7 @@ #include <smp/spinlock.h> #include <cpu/cpu.h> #include <cpu/intel/speedstep.h> +#include <stdlib.h> #include <thread.h>
/* This is a lot more paranoid now, since Linux can NOT handle diff --git a/src/cpu/x86/mirror_payload.c b/src/cpu/x86/mirror_payload.c index 88c5e81..f6420f2 100644 --- a/src/cpu/x86/mirror_payload.c +++ b/src/cpu/x86/mirror_payload.c @@ -14,12 +14,12 @@ */
#include <stdint.h> -#include <stdlib.h> #include <string.h> #include <commonlib/helpers.h> #include <console/console.h> #include <bootmem.h> #include <program_loading.h> +#include <stddef.h>
void mirror_payload(struct prog *payload) {
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33680
to look at the new patch set (#4).
Change subject: src/cpu: Use 'include <stdlib.h>' when appropriate ......................................................................
src/cpu: Use 'include <stdlib.h>' when appropriate
Also: add some missing includes spotted by Jenkins. Including <types.h>, is supposed to provide stdint and stddef.
Change-Id: I7bd999b59d1c0bdfa5999bf5805576f94c9a2390 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/family_10h-family_15h/fidvid.c M src/cpu/amd/family_10h-family_15h/processor_name.c M src/cpu/x86/lapic/lapic_cpu_init.c M src/cpu/x86/mirror_payload.c 4 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/33680/4
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33680 )
Change subject: src/cpu: Use 'include <stdlib.h>' when appropriate ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33680 )
Change subject: src/cpu: Use 'include <stdlib.h>' when appropriate ......................................................................
src/cpu: Use 'include <stdlib.h>' when appropriate
Also: add some missing includes spotted by Jenkins. Including <types.h>, is supposed to provide stdint and stddef.
Change-Id: I7bd999b59d1c0bdfa5999bf5805576f94c9a2390 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33680 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/cpu/amd/family_10h-family_15h/fidvid.c M src/cpu/amd/family_10h-family_15h/processor_name.c M src/cpu/x86/lapic/lapic_cpu_init.c M src/cpu/x86/mirror_payload.c 4 files changed, 5 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/cpu/amd/family_10h-family_15h/fidvid.c b/src/cpu/amd/family_10h-family_15h/fidvid.c index 917cde3..57207a4 100644 --- a/src/cpu/amd/family_10h-family_15h/fidvid.c +++ b/src/cpu/amd/family_10h-family_15h/fidvid.c @@ -91,6 +91,7 @@ #include <device/pci_ops.h> #include <stdint.h> #include <northbridge/amd/amdht/AsPsDefs.h> +#include <stdlib.h>
static inline void print_debug_fv(const char *str, u32 val) { diff --git a/src/cpu/amd/family_10h-family_15h/processor_name.c b/src/cpu/amd/family_10h-family_15h/processor_name.c index fbd2bb5..c5e31fd 100644 --- a/src/cpu/amd/family_10h-family_15h/processor_name.c +++ b/src/cpu/amd/family_10h-family_15h/processor_name.c @@ -27,6 +27,8 @@ #include <device/pci.h> #include <device/pnp.h> #include <device/pci_ops.h> +#include <stdlib.h> +#include <types.h>
/* The maximum length of CPU names is 48 bytes, including the final NULL byte. * If you change these names your BIOS will _NOT_ pass the AMD validation and diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index 668988a..e7dfc57 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -28,6 +28,7 @@ #include <smp/spinlock.h> #include <cpu/cpu.h> #include <cpu/intel/speedstep.h> +#include <stdlib.h> #include <thread.h>
/* This is a lot more paranoid now, since Linux can NOT handle diff --git a/src/cpu/x86/mirror_payload.c b/src/cpu/x86/mirror_payload.c index 9dec8db..9987347 100644 --- a/src/cpu/x86/mirror_payload.c +++ b/src/cpu/x86/mirror_payload.c @@ -11,13 +11,12 @@ * GNU General Public License for more details. */
-#include <stdint.h> -#include <stdlib.h> #include <string.h> #include <commonlib/helpers.h> #include <console/console.h> #include <bootmem.h> #include <program_loading.h> +#include <types.h>
void mirror_payload(struct prog *payload) {
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)