Attention is currently required from: Felix Held, Paul Menzel.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82631?usp=email )
Change subject: sio/nuvoton: Add Kconfig for shared PS/2 port ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82631/comment/4537724a_642b17c8?usp... : PS1, Line 11: On these boards (where a Y-cable cannot allow both : keyboard and mouse to work off the same port), if a PS/2 keyboard is : not present, SIO should be configured to swap its role to mouse, to : allow the OS to find and initialize any mouse connected.
Just to avoid misunderstandings. […]
It is definitely board dependent. The PS/2 port have enough pins to carry both mouse and keyboard clock and data. But they have to be pinned in a particular way and have a matching Y-cable the breaks the two ports out properly. I can assume that most if not all will default that port to keyboards and will have to rely on the super i/O chip to use the keyboard lanes to carry mouse data, which the next 2 patches in the train will address.
File src/superio/nuvoton/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/82631/comment/c84d3983_35406baf?usp... : PS1, Line 15: HAVE_SHARED_PS2_PORT
Should this be namespaced, or could it be moved to `src/superio/Kconfig`?
There is no src/superio/Kconfig. It probably should go to src/mainboard/Kconfig like the state after power loss option, but maybe that should wait till wide adoption e.g. ITE SIOs getting this feature as well. Some devs here actually prefer this option be replicated over there when that happens, when we discussed other things with similar wider adoption potential.
-
Keith Hui (Code Review)