Change in ...coreboot[master]: Aleena/Kasumi: Add support Synaptics touch pad for Aleena/Kasumi
Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31064
Change subject: Aleena/Kasumi: Add support Synaptics touch pad for Aleena/Kasumi ......................................................................
Aleena/Kasumi: Add support Synaptics touch pad for Aleena/Kasumi
Add support Synaptics touch pad for Aleena/Kasumi.
BUG=b:122549449 BRANCH=master TEST= Check if synaptics touch pad working in ChromeOS.
Change-Id: Icab1b312f1943b27037ef458044ce9e7172919ee Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com --- M src/mainboard/google/kahlee/variants/aleena/devicetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31064/1
diff --git a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb index fd807c4..c55bb8b 100644 --- a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb @@ -138,8 +138,18 @@ register "desc" = ""ELAN Touchpad"" register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" register "wake" = "7" + register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" + register "generic.wake" = "7" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end end device mmio 0xfedc5000 on chip drivers/i2c/generic
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31064 )
Change subject: Aleena/Kasumi: Add support Synaptics touch pad for Aleena/Kasumi ......................................................................
Patch Set 1: Code-Review+1
David Wu has uploaded a new patch set (#2) to the change originally created by Lucas Chen. ( https://review.coreboot.org/c/coreboot/+/31064 )
Change subject: mb/google/kahlee/variants/aleena: Add support Synaptics touch pad ......................................................................
mb/google/kahlee/variants/aleena: Add support Synaptics touch pad
Add support Synaptics touch pad for Aleena/Kasumi.
BUG=b:122549449 BRANCH=master TEST= Check if synaptics touch pad working in ChromeOS.
Change-Id: Icab1b312f1943b27037ef458044ce9e7172919ee Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com --- M src/mainboard/google/kahlee/variants/aleena/devicetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31064/2
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31064 )
Change subject: mb/google/kahlee/variants/aleena: Add support Synaptics touch pad ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31064 )
Change subject: mb/google/kahlee/variants/aleena: Add support Synaptics touch pad ......................................................................
mb/google/kahlee/variants/aleena: Add support Synaptics touch pad
Add support Synaptics touch pad for Aleena/Kasumi.
BUG=b:122549449 BRANCH=master TEST= Check if synaptics touch pad working in ChromeOS.
Change-Id: Icab1b312f1943b27037ef458044ce9e7172919ee Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/31064 Reviewed-by: Daniel Kurtz djkurtz@google.com Reviewed-by: David Wu david_wu@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kahlee/variants/aleena/devicetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Daniel Kurtz: Looks good to me, approved David Wu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb index fd807c4..c55bb8b 100644 --- a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb @@ -138,8 +138,18 @@ register "desc" = ""ELAN Touchpad"" register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" register "wake" = "7" + register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" + register "generic.wake" = "7" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end end device mmio 0xfedc5000 on chip drivers/i2c/generic
-
Daniel Kurtz (Code Review) -
David Wu (Code Review)
-
Lucas Chen (Code Review)
-
Patrick Georgi (Code Review)