Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Patrick Rudolph.
Ana Carolina Cabral has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86585?usp=email )
Change subject: soc/amd/glinda: Move AMDFWBODY to upper 16MiB
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/amd/birman_plus/Kconfig:
https://review.coreboot.org/c/coreboot/+/86585/comment/ae9b5d69_869531d8?usp... :
PS1, Line 5: BOARD_ROMSIZE_KB_65536
Isn't it 512-Mbit flash SPI ROM? (from schematics and user guide)
Ops, MiB confused me.. sorry
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86585?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifdc8618a87588469eb8801cb73eb25cdca486adf
Gerrit-Change-Number: 86585
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Feb 2025 10:38:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ana Carolina Cabral
ana.cpmelo95@gmail.com