Hello Yuchen Huang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/46883
to review the following change.
Change subject: soc/mediatek/mt8192: add rtc MT6359P lpd_init ......................................................................
soc/mediatek/mt8192: add rtc MT6359P lpd_init
add rtc low power detect init
TEST=boot asurada
Signed-off-by: Yuchen Huang yuchen.huang@mediatek.corp-partner.google.com Change-Id: Ia5d707a991beb307d4a664ac5e749491245ea776 --- M src/soc/mediatek/common/rtc.c M src/soc/mediatek/mt8192/rtc.c 2 files changed, 6 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/46883/1
diff --git a/src/soc/mediatek/common/rtc.c b/src/soc/mediatek/common/rtc.c index 5ac19eb..d5b12df 100755 --- a/src/soc/mediatek/common/rtc.c +++ b/src/soc/mediatek/common/rtc.c @@ -141,6 +141,9 @@
rtc_info("con=%x, pwrkey1=%x, pwrkey2=%x\n", con, pwrky1, pwrky2);
+ if (con & RTC_CON_LPSTA_RAW) + return RTC_STATE_INIT; + if (!rtc_busy_wait()) return RTC_STATE_RECOVER;
diff --git a/src/soc/mediatek/mt8192/rtc.c b/src/soc/mediatek/mt8192/rtc.c index ca817fa..b582df1 100755 --- a/src/soc/mediatek/mt8192/rtc.c +++ b/src/soc/mediatek/mt8192/rtc.c @@ -272,9 +272,9 @@ { u16 con, sec;
- /* disable both XOSC & EOSC LPD */ + /* enable both XOSC & EOSC LPD */ rtc_read(RTC_AL_SEC, &sec); - sec |= RTC_LPD_OPT_F32K_CK_ALIVE; + sec &= ~RTC_LPD_OPT_F32K_CK_ALIVE; rtc_write(RTC_AL_SEC, sec);
if (!rtc_write_trigger()) @@ -295,16 +295,7 @@ return 0;
rtc_read(RTC_CON, &con); - con &= ~RTC_CON_XOSC32_LPEN; - rtc_write(RTC_CON, con); - /*Enable RTC_LPD_OPT: EOSC LPD*/ - rtc_read(RTC_AL_SEC, &sec); - sec &= ~RTC_LPD_OPT_MASK; - sec |= RTC_LPD_OPT_EOSC_LPD; - rtc_write(RTC_AL_SEC, sec); - - if (!rtc_write_trigger()) - return 0; + rtc_info("check RTC_CON_LPSTA_RAW after LP init: %x\n", con);
return 1; }
Hello build bot (Jenkins), Ran Bi, Yuchen Huang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46883
to look at the new patch set (#13).
Change subject: soc/mediatek/mt8192: add rtc MT6359P lpd_init ......................................................................
soc/mediatek/mt8192: add rtc MT6359P lpd_init
add rtc low power detect init
TEST=boot asurada
Signed-off-by: Yuchen Huang yuchen.huang@mediatek.corp-partner.google.com Change-Id: Ia5d707a991beb307d4a664ac5e749491245ea776 --- M src/soc/mediatek/common/rtc.c M src/soc/mediatek/mt8192/rtc.c 2 files changed, 6 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/46883/13
Hello Hung-Te Lin, Xi Chen, build bot (Jenkins), Ran Bi, Yuchen Huang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46883
to look at the new patch set (#24).
Change subject: soc/mediatek/mt8192: add rtc MT6359P lpd_init ......................................................................
soc/mediatek/mt8192: add rtc MT6359P lpd_init
add rtc low power detect init
TEST=boot asurada
Signed-off-by: Yuchen Huang yuchen.huang@mediatek.corp-partner.google.com Change-Id: Ia5d707a991beb307d4a664ac5e749491245ea776 --- M src/soc/mediatek/common/rtc.c M src/soc/mediatek/mt8192/rtc.c 2 files changed, 6 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/46883/24
Hello Hung-Te Lin, Xi Chen, build bot (Jenkins), Ran Bi, Yuchen Huang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46883
to look at the new patch set (#26).
Change subject: soc/mediatek/mt8192: add rtc MT6359P lpd_init ......................................................................
soc/mediatek/mt8192: add rtc MT6359P lpd_init
add rtc low power detect init
TEST=boot asurada
Signed-off-by: Yuchen Huang yuchen.huang@mediatek.corp-partner.google.com Change-Id: Ia5d707a991beb307d4a664ac5e749491245ea776 --- M src/soc/mediatek/common/rtc.c M src/soc/mediatek/mt8192/rtc.c 2 files changed, 6 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/46883/26
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46883 )
Change subject: soc/mediatek/mt8192: add rtc MT6359P lpd_init ......................................................................
Patch Set 30:
Merged into CB:46395. Will abandon it later.
Yidi Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46883 )
Change subject: soc/mediatek/mt8192: add rtc MT6359P lpd_init ......................................................................
Abandoned
squashed into CB:46395
-
Yidi Lin (Code Review)