Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27532 )
Change subject: nb/intel/sandybridge: Remove the C native graphic init
......................................................................
Patch Set 11:
I think this patch orphaned code in src/mainboard/google/link/i915.c, and (presumably) broke Link when selecting DO_NATIVE_VGA_INIT in menuconfig. If the intention was to get rid of that option entirely, can you please remove HAS_NATIVE_VGA_INIT and any associated code from affected boards?
Somebody must have missed your message ^^ I looked into it
and also fixed two more odd occurences of DO_NATIVE_VGA_INIT.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6678d3455f1116e7e67a67b465a79df020b2399
Gerrit-Change-Number: 27532
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 30 May 2019 13:33:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment