Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76811?usp=email )
Change subject: vendorcode/cavium: Use C99 flexible arrays ......................................................................
vendorcode/cavium: Use C99 flexible arrays
Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure.
Change-Id: I19c029968584fedbb6749e66c7ea2f74a7d580f4 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/76811 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth gaumless@gmail.com --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-nic.c M src/vendorcode/cavium/include/bdk/libbdk-hal/if/bdk-if.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-nic.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-nic.c index b6a9384..1a99636 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-nic.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-nic.c @@ -80,7 +80,7 @@ int next_free_cpi; int next_free_rssi; int next_free_bpid; - nic_t *nic_map[0]; /* Indexed by handle->nic_id */ + nic_t *nic_map[]; /* Indexed by handle->nic_id */ } nic_node_state_t;
static nic_node_state_t *global_node_state[BDK_NUMA_MAX_NODES]; diff --git a/src/vendorcode/cavium/include/bdk/libbdk-hal/if/bdk-if.h b/src/vendorcode/cavium/include/bdk/libbdk-hal/if/bdk-if.h index c3ede0a..b77aa2a 100644 --- a/src/vendorcode/cavium/include/bdk/libbdk-hal/if/bdk-if.h +++ b/src/vendorcode/cavium/include/bdk/libbdk-hal/if/bdk-if.h @@ -153,7 +153,7 @@ char name[16]; struct __bdk_if_port *next; struct __bdk_if_port *poll_next; - char priv[0]; + char priv[]; } __bdk_if_port_t;
typedef __bdk_if_port_t *bdk_if_handle_t;